Enable support for STS regional endpoints when configured to assume a role #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… role In AWS VPCs without internet access which have the STS VPC endpoint created the region needs to be explicitly along with the environment variable AWS_STS_REGIONAL_ENDPOINTS=regional otherwise the AWS Java SDK will use the global STS endpoint.
sayantacC
suggested changes
Aug 9, 2021
src/main/java/software/amazon/msk/auth/iam/internals/MSKCredentialProvider.java
Show resolved
Hide resolved
| @@ -202,6 +202,40 @@ STSAssumeRoleSessionCredentialsProvider createSTSRoleCredentialProvider(String r | |||
| Mockito.verify(mockStsRoleProvider, times(1)).close(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testAwsRoleArnSessionNameAndStsRegion() { | |||
There was a problem hiding this comment.
Thanks for adding a test.
sayantacC
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
In AWS VPCs without internet access which have the STS VPC endpoint created the region needs to be explicitly along with the environment variable AWS_STS_REGIONAL_ENDPOINTS=regional otherwise the AWS Java SDK will use the global STS endpoint.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.