Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly generate sts client endpoint override #166

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

jvdadda
Copy link
Contributor

@jvdadda jvdadda commented Apr 12, 2024

Issue #, if available: #165

Description of changes:

aws-sdk-v2 now needs the scheme of the url, use correct api to generate the sts endpoint override

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jvdadda jvdadda marked this pull request as ready for review April 12, 2024 07:12
@jvdadda jvdadda requested a review from a team as a code owner April 12, 2024 07:12
@KKcorps
Copy link

KKcorps commented Apr 13, 2024

I am also facing this same error in my setup. @sidyag is it possible to get this PR merged?

@jvdadda
Copy link
Contributor Author

jvdadda commented Apr 18, 2024

🆙 @hhkkxxx133 @sidyag

@hhkkxxx133 hhkkxxx133 merged commit c490e81 into aws:main Apr 18, 2024
@hhkkxxx133
Copy link
Contributor

Thanks for your contribution!

@dlabey
Copy link

dlabey commented May 21, 2024

@hhkkxxx133 can we get a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants