feat: replace regions with v2 api #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@sidyag And here is the last pull request that remove all java-sdk-v1 dependencies |
|
@sidyag friendly bump |
sidyag
reviewed
Jun 24, 2024
| @@ -61,15 +59,12 @@ public IAMOAuthBearerToken(String token) throws URISyntaxException { | |||
| byte[] decodedBytes = Base64.getUrlDecoder().decode(tokenBytes); | |||
| final String decodedPresignedUrl = new String(decodedBytes, StandardCharsets.UTF_8); | |||
| final URI uri = new URI(decodedPresignedUrl); | |||
| List<NameValuePair> params = URLEncodedUtils.parse(uri, StandardCharsets.UTF_8); | |||
There was a problem hiding this comment.
Why can't we use this anymore?
There was a problem hiding this comment.
Hi @sidyag , by removing AWS SDK V1, some transitive dependencies have been removed, then NameValuePair and URLEncodedUtils are no more available. I can have access again by adding org.apache.httpcomponents:httpclient:4.5.+ dependency if needed. I re-implemented the method to avoid adding the whole dependency
sidyag
reviewed
Jun 24, 2024
sidyag
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Replace the v1 region API with V2. I do not succeed to find an exact equivalent, so to try to extract the region from the host, I check if I find the region id in the string, and if not, fallback to the default region provider.
I removed the sdk V1 dependency that have remove few helper method (from transiant dependencies), I reimplemented them instead of adding an extra dependency.
It should end the V1 SDK, unit tests are green, I tested for my own case, it works, hoping it will for everyone
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Will resolve #154