Define RSASSA_PSS_PARAMS struct. #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-shang
requested review from
andrew-kaufman,
andrewhop and
torben-hansen
|
Closed. I will reuse |
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Nov 15, 2023
…ck_no Document that x25519 function does not implement zero-check s2n-bignum original commit: awslabs/s2n-bignum@5c4b15a
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Jul 22, 2024
…ck_no Document that x25519 function does not implement zero-check s2n-bignum original commit: awslabs/s2n-bignum@5c4b15a
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
…ck_no Document that x25519 function does not implement zero-check s2n-bignum original commit: awslabs/s2n-bignum@5c4b15a
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
…ck_no Document that x25519 function does not implement zero-check s2n-bignum original commit: awslabs/s2n-bignum@5c4b15a s2n-bignum original commit: awslabs/s2n-bignum@cc0e9f6
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 19, 2024
…ck_no Document that x25519 function does not implement zero-check s2n-bignum original commit: awslabs/s2n-bignum@5c4b15a
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 5, 2024
…ck_no Document that x25519 function does not implement zero-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses CryptoAlg-614
Description of changes:
This PR is to define RSASSA_PSS_PARAMS struct based on 3.1. https://tools.ietf.org/html/rfc4055#page-7
RSA_PSS_PARAMS in x509.h is not used to avoid the dependency on old ASN1 stack. See below link discussion
https://bugs.chromium.org/p/boringssl/issues/detail?id=395
OpenSSL 1.1.1 Compatibility
OpenSSL 1.1.1 adds new API to get pss parameters. Additional conversion between
RSASSA_PSS_PARAMSandRSA_PSS_PARAMSwill be needed when awslc addsRSA_get0_pss_params.Call-outs:
Testing:
No test. No usage of this struct.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.