Migrate to CodeBuild batch. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a72c367.
| @@ -27,9 +27,9 @@ fi | |||
|
|
|||
| if [ $(dpkg --print-architecture) == "amd64" ]; then | |||
| # x86 TSAN runs get stuck on PoolTest.Threads for over an hour https://github.com/awslabs/aws-lc/issues/13 | |||
There was a problem hiding this comment.
Is this comment still relevant? The issue has been closed for a while now.
There was a problem hiding this comment.
If we don't need it anymore, can we also remove the comment on line 20 as well?
There was a problem hiding this comment.
The comment explained why test is not executed. run_build instead of build_and_test is used in this condition.
andrewhop
reviewed
Oct 5, 2020
andrewhop
approved these changes
Oct 5, 2020
andrew-kaufman
approved these changes
Oct 6, 2020
bryce-shang
added a commit
to bryce-shang/aws-lc
that referenced
this pull request
Oct 19, 2020
* Add batch build spec. * Use batch-list. * Remove invalid characters from identifier. * Fix syntax warning. * Upgrade cdk to latest version 1.64. * Add github_codebuild_batch_stack.py. * Move build specs. * Refactor cdk code. * Use aws-lc AWS account. * Unify default values of env variable. * Fix windows docker build issue. * Add s3 bucket deletion when destroy resource. * Add new variable github_source_version. * Upgrade ec2 windows from 2016 to 2019. * Add git to PATH. * Revert "Upgrade ec2 windows from 2016 to 2019." This reverts commit a72c367. * Add 2019 windows. * Move cyg and quilt installation to build spec. * Add docker image build doc. * Fix identifier name. * Switch to 2016. CodeBuild does not support 2019. * Clean up and add more docs. * Fix typo. * Modify README.md * Remove '*'. * Change privileged-mode to false. * ARM sanitizer needs privileged-mode.
bryce-shang
added a commit
to bryce-shang/aws-lc
that referenced
this pull request
Oct 20, 2020
* Add batch build spec. * Use batch-list. * Remove invalid characters from identifier. * Fix syntax warning. * Upgrade cdk to latest version 1.64. * Add github_codebuild_batch_stack.py. * Move build specs. * Refactor cdk code. * Use aws-lc AWS account. * Unify default values of env variable. * Fix windows docker build issue. * Add s3 bucket deletion when destroy resource. * Add new variable github_source_version. * Upgrade ec2 windows from 2016 to 2019. * Add git to PATH. * Revert "Upgrade ec2 windows from 2016 to 2019." This reverts commit a72c367. * Add 2019 windows. * Move cyg and quilt installation to build spec. * Add docker image build doc. * Fix identifier name. * Switch to 2016. CodeBuild does not support 2019. * Clean up and add more docs. * Fix typo. * Modify README.md * Remove '*'. * Change privileged-mode to false. * ARM sanitizer needs privileged-mode.
bryce-shang
added a commit
to bryce-shang/aws-lc
that referenced
this pull request
Oct 22, 2020
* Add batch build spec. * Use batch-list. * Remove invalid characters from identifier. * Fix syntax warning. * Upgrade cdk to latest version 1.64. * Add github_codebuild_batch_stack.py. * Move build specs. * Refactor cdk code. * Use aws-lc AWS account. * Unify default values of env variable. * Fix windows docker build issue. * Add s3 bucket deletion when destroy resource. * Add new variable github_source_version. * Upgrade ec2 windows from 2016 to 2019. * Add git to PATH. * Revert "Upgrade ec2 windows from 2016 to 2019." This reverts commit a72c367. * Add 2019 windows. * Move cyg and quilt installation to build spec. * Add docker image build doc. * Fix identifier name. * Switch to 2016. CodeBuild does not support 2019. * Clean up and add more docs. * Fix typo. * Modify README.md * Remove '*'. * Change privileged-mode to false. * ARM sanitizer needs privileged-mode.
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Nov 15, 2023
Add support for 8 more NEON instructions s2n-bignum original commit: awslabs/s2n-bignum@8337486
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
Add support for 8 more NEON instructions s2n-bignum original commit: awslabs/s2n-bignum@8337486 s2n-bignum original commit: awslabs/s2n-bignum@935b9dc
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 5, 2024
Add support for 8 more NEON instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves CryptoAlg-489
Description of changes:
This PR migrates CodeBuild build type from single to batch.
This migration gets below items involved:
tests/ci/cdk/util/iam_policies.py.tests/ci/cdk/util/metadata.py.choco install cyg-get && cyg-get install quiltinstallation is moved from Docker image build to CodeBuild spec due to hcsshim::ImportLayer failed in Win32: The system cannot find the path specified. (0x3) on Docker Desktop for Windows Community edition 2.3.0.3(45519) microsoft/hcsshim#835Call-outs:
CryptoAlg-575: CFN CodeBuild is still releasingBUILD_BATCHtype. Current workaround is to useAWS CLIto update webhook build type.Testing:
Open aws-lc AWS account and check CodeBuild
aws-lc-ci, which has not webhook to this repo due to the limit.Next Steps:
aws-lc-ci.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.