Improve tool-openssl compatability for x509 and verify subcommands #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
- Coverage 79.05% 79.05% -0.01%
==========================================
Files 612 612
Lines 106159 106210 +51
Branches 15002 15008 +6
==========================================
+ Hits 83923 83961 +38
- Misses 21582 21599 +17
+ Partials 654 650 -4 ☔ View full report in Codecov by Sentry. |
skmcgrail
force-pushed
the
tool-compat
branch
from
3cb915a to
cb56582
Compare
torben-hansen
previously approved these changes
Feb 13, 2025
skmcgrail
force-pushed
the
tool-compat
branch
from
95d4aa2 to
608c977
Compare
smittals2
reviewed
Feb 17, 2025
smittals2
reviewed
Feb 17, 2025
|
Can we add a test for the new -untrusted option? I remember there were some issues with output being differently formatted between OpenSSL and AWS-LC (I don't remember if this was X509 or verify though). If that is why this test was not added, ignore the comment. |
torben-hansen
previously approved these changes
Feb 18, 2025
torben-hansen
changed the title
torben-hansen
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
pemorderwhen using the-informargument to thex509sub-command.-untrustedflag to theverifysub-command which allows for passing in a set of one or more chain certificates which may be used in the certificate chain building and validation.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.