Enable RDRAND for all x86_64 except known prohibitively slow CPU models #2135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove the need to have a "fast" rdrand. Instead flip the model to exclude known prohibitively slow rdrand implementations. In particular, this includes the AMD Zen1 and Zen2 generation microarchitectures. See q/VxC3AiwXpAjJ for some data on that.
This change is made to increase the usage of prediction resistance.
Testing:
To test the new family detection, I patched like this:
and ran the code on both a c5a and c6a instance. The former is Zen2 based, the latter is Zen3 based.
c5a:
c6a:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.