Init variable to avoid "may be used uninitialized" warning #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2114 +/- ##
=======================================
Coverage 78.92% 78.92%
=======================================
Files 610 610
Lines 105121 105123 +2
Branches 14904 14902 -2
=======================================
+ Hits 82967 82971 +4
+ Misses 21503 21500 -3
- Partials 651 652 +1 ☔ View full report in Codecov by Sentry. |
manastasova
force-pushed
the
uninit_ci_fails
branch
from
9424cfa to
a904cb8
Compare
crypto/fipsmodule/ec/ec_montgomery.c
Outdated
|
|
||
| // Initialize variables to avoid "may be used uninitialized" warning. | ||
| // https://github.com/aws/aws-lc/issues/1185 | ||
| EC_FELEM delta = {{0}}, gamma = {{0}}, beta = {{0}}, ftmp = {{0}}, ftmp2 = {{0}}, tmptmp = {{0}}, alpha = {{0}}, fourbeta = {{0}}; |
There was a problem hiding this comment.
nitpick: at 134 characters, this line has gotten a little long. you might want to break it up into 2 lines.
There was a problem hiding this comment.
Thanks, Will. Addressed.
WillChilds-Klein
previously approved these changes
Jan 14, 2025
justsmth
approved these changes
Jan 14, 2025
WillChilds-Klein
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous discussion here: #1185
Similar issues here: 305ec03
Similar issues here: d0501c5#diff-6fde57725bf74f073ccac9d404387d74a39824fbc2465a02cfe37e86e679bbe8R34
Causes CI fails
Issues:
Resolves #P188618529
Description of changes:
Zero variables before use.
Call-outs:
The fail only occurs for gcc-12 with ubuntu2204 on x86_64.
Only variables
|ftmp2|and|fourbeta|are caught as maybe uninitializederror: 'var_name' may be used uninitialized [-Werror=maybe-uninitialized].Testing:
CI tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.