Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mldsa and pqdsa out of fipsmodule #2104

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

jakemas
Copy link
Contributor

@jakemas jakemas commented Jan 10, 2025

Issues:

Issues with the delocator is preventing ML-DSA from being added to bcm.c. This PR moves PQDSA and ML-DSA out of the fipsmodule.

Description of changes:

  • Had to remove uses of delocator (e.g DEFINE_LOCAL_DATA) and replaced with traditional methods.
  • Also had to change the number of FIPS methods, and redefine those new methods without use of the delocator.
  • Only essential changes were included in this PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@jakemas jakemas requested a review from a team as a code owner January 10, 2025 18:10
justsmth
justsmth previously approved these changes Jan 10, 2025
@justsmth justsmth self-requested a review January 10, 2025 18:22
@justsmth
Copy link
Contributor

Strange build failure on Macs: https://github.com/aws/aws-lc/actions/runs/12714896925/job/35446197733?pr=2104#step:4:8685

 File not embedded: crypto/fipsmodule/ml_dsa/kat/MLDSA_44_hedged_pure.txt.
OPENSSL_armcap=0x3D crypto/crypto_test [shard 4/6]
crypto/crypto_test failed to complete: signal: abort trap

@jakemas
Copy link
Contributor Author

jakemas commented Jan 10, 2025

9057099

Thank you! spotted and fixed in 9057099 (KAT filepath is partially hardcoded)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (5084e19) to head (9057099).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2104      +/-   ##
==========================================
- Coverage   78.77%   78.76%   -0.01%     
==========================================
  Files         598      598              
  Lines      103656   103657       +1     
  Branches    14719    14720       +1     
==========================================
- Hits        81650    81645       -5     
- Misses      21354    21359       +5     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhop andrewhop enabled auto-merge (squash) January 10, 2025 20:35
@andrewhop andrewhop merged commit e34998e into aws:main Jan 10, 2025
123 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants