Just use releasecheck with tcpdump ci #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2055 +/- ##
=======================================
Coverage 78.77% 78.77%
=======================================
Files 598 598
Lines 103683 103683
Branches 14742 14743 +1
=======================================
+ Hits 81672 81676 +4
+ Misses 21359 21354 -5
- Partials 652 653 +1 ☔ View full report in Codecov by Sentry. |
andrewhop
approved these changes
Dec 12, 2024
darylmartin100
approved these changes
Dec 12, 2024
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Dec 13, 2024
The CI issues we've been having stems from some new tests tcpdump has for the upcoming 2038 problem. However, these tests will fail with outdated versions of libpcap that don't support the preprocessor macro `_TIME_BITS` (Documented in the-tcpdump-group/tcpdump#1147) **Tcpdump's fixed the issue when running release-check: the-tcpdump-group/tcpdump@0546e6a. Release-check already runs with check and runs all the tests, but with a more defined process.** Since upstream's just running release-check to encapsulate everything, I think we can just run release-check here to get rid of CI issues. ### Call-outs: N/A ### Testing: CI By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
V1564319359Description of changes:
The CI issues we've been having stems from some new tests tcpdump has for the upcoming 2038 problem. However, these tests will fail with outdated versions of libpcap that don't support the preprocessor macro
_TIME_BITS(Documented in the-tcpdump-group/tcpdump#1147)Tcpdump's fixed the issue when running release-check: the-tcpdump-group/tcpdump@0546e6a. Release-check already runs with check and runs all the tests, but with a more defined process.
Since upstream's just running release-check to encapsulate everything, I think we can just run release-check here to get rid of CI issues.
Call-outs:
N/A
Testing:
CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.