Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure sequence numbers are allowed to increase by more than one #1667

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

maddeleine
Copy link
Contributor

@maddeleine maddeleine commented Jun 26, 2024

Issues:

P131226031

Description of changes:

EVP_aead_aes_128_gcm_tls13() and EVP_aead_aes_256_gcm_tls13() are currently required to encrypt with a monotonically-increasing sequence number. This sequence number however is allowed to increase by more than 1 per encrypt call. This PR adds a test to codify this behavior.

Call-outs:

Testing:

Adds test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@maddeleine maddeleine requested a review from a team as a code owner June 26, 2024 00:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (90315e2) to head (88cb7dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   78.22%   78.22%   -0.01%     
==========================================
  Files         571      571              
  Lines       95519    95533      +14     
  Branches    13699    13700       +1     
==========================================
+ Hits        74719    74729      +10     
- Misses      20188    20194       +6     
+ Partials      612      610       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BUILDING.md Outdated Show resolved Hide resolved
crypto/cipher_extra/aead_test.cc Outdated Show resolved Hide resolved
crypto/cipher_extra/aead_test.cc Outdated Show resolved Hide resolved
crypto/cipher_extra/aead_test.cc Show resolved Hide resolved
crypto/cipher_extra/aead_test.cc Outdated Show resolved Hide resolved
crypto/cipher_extra/aead_test.cc Outdated Show resolved Hide resolved
@maddeleine maddeleine requested review from justsmth and andrewhop July 3, 2024 19:10
@maddeleine maddeleine requested a review from andrewhop July 9, 2024 19:15
@justsmth justsmth merged commit fa8b98e into aws:main Jul 12, 2024
100 of 101 checks passed
@maddeleine maddeleine deleted the monotonicity_check branch July 12, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants