-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial x509 tool #1666
Add initial x509 tool #1666
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1666 +/- ##
==========================================
- Coverage 78.26% 78.19% -0.07%
==========================================
Files 567 571 +4
Lines 95238 95400 +162
Branches 13673 13704 +31
==========================================
+ Hits 74535 74600 +65
- Misses 20109 20189 +80
- Partials 594 611 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the SDE tests are failing. This is probably because there's a test creating and deleting files (test_input/output.der
), but the SDE tests are continuously running our test on multiple different processes/threads. This causes a race condition.
We've ran into this before and got around it by using tmpfile
s. This should get around your CI issues.
Description: - Developed structure for new OpenSSL tools - Contains initial implementation for OpenSSL x509 tool, options -in and -out (x509.cc), and unit test (x509_test.cc) - x509_test.cc contains test portions ultimately to be used for future options but unnecessary for -in/-out unit test _Files expected to change_ By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 3da2c4a)
Description: - Developed structure for new OpenSSL tools - Contains initial implementation for OpenSSL x509 tool, options -in and -out (x509.cc), and unit test (x509_test.cc) - x509_test.cc contains test portions ultimately to be used for future options but unnecessary for -in/-out unit test _Files expected to change_ By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 3da2c4a)
Description:
Files expected to change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.