Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial x509 tool #1666

Merged
merged 16 commits into from
Jul 2, 2024
Merged

Add initial x509 tool #1666

merged 16 commits into from
Jul 2, 2024

Conversation

ecdeye
Copy link
Contributor

@ecdeye ecdeye commented Jun 25, 2024

Description:

  • Developed structure for new OpenSSL tools
  • Contains initial implementation for OpenSSL x509 tool, options -in and -out (x509.cc), and unit test (x509_test.cc)
  • x509_test.cc contains test portions ultimately to be used for future options but unnecessary for -in/-out unit test

Files expected to change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@ecdeye ecdeye requested a review from a team as a code owner June 25, 2024 23:50
@ecdeye ecdeye requested a review from justsmth June 25, 2024 23:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 59.45946% with 30 lines in your changes missing coverage. Please review.

Project coverage is 78.19%. Comparing base (21c5e48) to head (af1d491).

Files Patch % Lines
tool-openssl/x509.cc 48.78% 21 Missing ⚠️
tool-openssl/x509_test.cc 72.72% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   78.26%   78.19%   -0.07%     
==========================================
  Files         567      571       +4     
  Lines       95238    95400     +162     
  Branches    13673    13704      +31     
==========================================
+ Hits        74535    74600      +65     
- Misses      20109    20189      +80     
- Partials      594      611      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tool-openssl/CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
tool-openssl/CMakeLists.txt Outdated Show resolved Hide resolved
tool-openssl/tool.cc Show resolved Hide resolved
tool-openssl/tool.cc Show resolved Hide resolved
tool-openssl/tool.cc Show resolved Hide resolved
tool-openssl/tool.cc Outdated Show resolved Hide resolved
tool-openssl/tool.cc Outdated Show resolved Hide resolved
tool-openssl/x509.cc Outdated Show resolved Hide resolved
tool-openssl/x509_test.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@samuel40791765 samuel40791765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the SDE tests are failing. This is probably because there's a test creating and deleting files (test_input/output.der), but the SDE tests are continuously running our test on multiple different processes/threads. This causes a race condition.
We've ran into this before and got around it by using tmpfiles. This should get around your CI issues.

util/all_tests.json Outdated Show resolved Hide resolved
tool-openssl/x509_test.cc Outdated Show resolved Hide resolved
tool-openssl/x509_test.cc Outdated Show resolved Hide resolved
tool-openssl/x509.cc Outdated Show resolved Hide resolved
tool-openssl/x509.cc Outdated Show resolved Hide resolved
tool-openssl/x509_test.cc Outdated Show resolved Hide resolved
tool-openssl/x509_test.cc Outdated Show resolved Hide resolved
tool-openssl/x509_test.cc Show resolved Hide resolved
tool-openssl/x509_test.cc Outdated Show resolved Hide resolved
tool-openssl/CMakeLists.txt Outdated Show resolved Hide resolved
tool-openssl/tool.cc Outdated Show resolved Hide resolved
tool-openssl/tool.cc Show resolved Hide resolved
tool-openssl/x509_test.cc Outdated Show resolved Hide resolved
justsmth
justsmth previously approved these changes Jul 1, 2024
@ecdeye ecdeye requested review from samuel40791765 and justsmth July 1, 2024 20:36
@ecdeye ecdeye merged commit 3da2c4a into aws:main Jul 2, 2024
96 of 99 checks passed
samuel40791765 pushed a commit to samuel40791765/aws-lc that referenced this pull request Aug 14, 2024
Description:
- Developed structure for new OpenSSL tools
- Contains initial implementation for OpenSSL x509 tool, options -in and
-out (x509.cc), and unit test (x509_test.cc)
- x509_test.cc contains test portions ultimately to be used for future
options but unnecessary for -in/-out unit test

_Files expected to change_

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.

(cherry picked from commit 3da2c4a)
samuel40791765 pushed a commit that referenced this pull request Aug 15, 2024
Description:
- Developed structure for new OpenSSL tools
- Contains initial implementation for OpenSSL x509 tool, options -in and
-out (x509.cc), and unit test (x509_test.cc)
- x509_test.cc contains test portions ultimately to be used for future
options but unnecessary for -in/-out unit test

_Files expected to change_

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.

(cherry picked from commit 3da2c4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants