Add point add/dbl to ec_nistp_felem_meth and rename it to ec_nistp_meth #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebeid
reviewed
Jun 21, 2024
| @@ -34,7 +34,7 @@ typedef uint64_t ec_nistp_felem_limb; | |||
| typedef uint32_t ec_nistp_felem_limb; | |||
| #endif | |||
|
|
|||
| // ec_nistp_felem_meth is a struct that holds pointers to implementations of field | |||
| // ec_nistp_meth is a struct that holds pointers to implementations of field | |||
There was a problem hiding this comment.
The rest of the documentation would need to be adjusted to not only mention field arithmetic functions.
crypto/fipsmodule/ec/ec_nistp.h
Outdated
| void ec_nistp_point_double(const ec_nistp_felem_meth *ctx, | ||
| } ec_nistp_meth; | ||
|
|
||
| const ec_nistp_meth *p256_felem_methods(void); |
There was a problem hiding this comment.
If the methods contain more than felem now, maybe you'd want to rename them.
There was a problem hiding this comment.
right, thanks for noticing!
nebeid
approved these changes
Jun 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
=======================================
Coverage ? 78.21%
=======================================
Files ? 566
Lines ? 95175
Branches ? 13661
=======================================
Hits ? 74443
Misses ? 20137
Partials ? 595 ☔ View full report in Codecov by Sentry. |
torben-hansen
approved these changes
Jun 24, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
Add point add/dbl to ec_nistp_felem_meth and rename it to ec_nistp_meth.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.