Update the BoringSSL benchmark to install libdecrepit #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
changed the title
justsmth
approved these changes
Mar 21, 2024
skmcgrail
approved these changes
Mar 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1505 +/- ##
==========================================
- Coverage 77.03% 76.97% -0.06%
==========================================
Files 425 425
Lines 71556 71556
==========================================
- Hits 55123 55082 -41
- Misses 16433 16474 +41 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
BoringSSL does not install libdecrepit by default, so our benchmark patches the file to install it to simplify our testing. They recently moved this to sources.cmake and the top level CMakeList.txt in google/boringssl@0cb032a. This causes issues for CI which now doesn't install libdecrepit and then fails to link the AES XTS implementation from libdecrepit. This change updates that.
Testing:
Ran locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.