RSA key check consolidation part 2 #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
==========================================
- Coverage 77.00% 76.98% -0.02%
==========================================
Files 425 425
Lines 71556 71546 -10
==========================================
- Hits 55103 55083 -20
- Misses 16453 16463 +10 ☔ View full report in Codecov by Sentry. |
skmcgrail
approved these changes
Mar 21, 2024
justsmth
approved these changes
Mar 22, 2024
Comment on lines
+1174
to
+1176
| if (boringssl_fips_break_test("RSA_PWCT")) { | ||
| data[0] = ~data[0]; | ||
| } |
There was a problem hiding this comment.
NP: This will be optimized away for release build, but we could guard this logic with #ifdef BORINGSSL_FIPS_BREAK_TESTS,
nebeid
reviewed
Mar 25, 2024
| // In addition to invalid key type, stripped private keys can not be checked | ||
| // with this function because they lack the public component which is | ||
| // necessary for both FIPS checks performed here. | ||
| if (key_type == RSA_KEY_TYPE_FOR_CHECKING_INVALID || |
There was a problem hiding this comment.
The RSA_is_opaque no longer applies?
| goto end; | ||
| } | ||
|
|
||
| if (!RSA_sign(NID_sha256, data, sizeof(data), sig, &sig_len, key)) { |
There was a problem hiding this comment.
We needed to use the EVP_DigestSign/Verify for the PCT test dbedeb7
nebeid
reviewed
Mar 25, 2024
| data[0] = ~data[0]; | ||
| } | ||
| if (!RSA_verify(NID_sha256, data, sizeof(data), sig, sig_len, key)) { | ||
| OPENSSL_PUT_ERROR(RSA, ERR_R_INTERNAL_ERROR); |
There was a problem hiding this comment.
Why not keep RSA_R_PUBLIC_KEY_VALIDATION_FAILED in the case of PCT failure as before?
Comment on lines
+1174
to
+1176
| if (boringssl_fips_break_test("RSA_PWCT")) { | ||
| data[0] = ~data[0]; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2280
Description of changes:
This change tidies up and adds documentation for
RSA_check_fipsfunction. The only technical change is the implementation of the
pair-wise consistency check which was replaced with the one from
BoringSSL for simplicity.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.