Update return value from EVP_Encode_Update in one error case #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
- Coverage 77.00% 77.00% -0.01%
==========================================
Files 425 425
Lines 71525 71525
==========================================
- Hits 55078 55077 -1
- Misses 16447 16448 +1 ☔ View full report in Codecov by Sentry. |
dkostic
approved these changes
Mar 15, 2024
smittals2
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #P121857409
Description of changes:
Coverity pointed that total was not used in this
ifstatement which returns right away. It was because of introducing the return statements in 6d9a767.The comments indicate that the intention is to update out_len as on line 180.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.