Error Codes for NodeJS compatibility added #1475
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
==========================================
- Coverage 77.00% 76.99% -0.01%
==========================================
Files 425 425
Lines 71627 71627
==========================================
- Hits 55154 55152 -2
- Misses 16473 16475 +2 ☔ View full report in Codecov by Sentry. |
| #define ERR_LIB_CT 41 | ||
| #define ERR_LIB_ASYNC 42 | ||
| #define ERR_LIB_KDF 43 | ||
| #define ERR_LIB_SM2 44 |
There was a problem hiding this comment.
Hmmmmmmm, does NodeJS not handle OPENSSL_NO_SM2 correctly?
There was a problem hiding this comment.
Not sure but they define mappings to these specific ERR_LIB_* codes, so we need to define them as well.
There was a problem hiding this comment.
Where do you see that? A naive search only finds the OpenSSL dependency code and no real usage https://github.com/search?q=repo%3Anodejs%2Fnode%20ERR_LIB_SM2&type=code
There was a problem hiding this comment.
They create a mapping to those err codes here:
https://github.com/nodejs/node/blob/1abff073921bcb0631602032aef0135bccfaee0d/src/crypto/crypto_util.cc#L501
Description of changes:
Added in some error codes from OpenSSL
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.