Adds CI job to test strongSwan integration #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CI job tests AWS-LC against the tip of strongswan/master. We use AWS-LC's shared library build and override the libcrypto used by strongSwan by setting LD_LIBRARY_PATH. We also run through strongSwan's unit test framework to make sure there are no correctness issues.
WillChilds-Klein
approved these changes
Mar 6, 2024
andrewhop
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves PQCrypto-7
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
This CI job tests AWS-LC against the tip of strongswan/master. We use
AWS-LC's shared library build and override the libcrypto used by
strongSwan by setting LD_LIBRARY_PATH. We also run through strongSwan's
unit test framework to make sure there are no correctness issues.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
act -W .github/workflows/integrations.yml -j strongswanBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.