Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental deletion in f3e49b01 #1357

Merged

Conversation

WillChilds-Klein
Copy link
Contributor

Issues:

  • n/a

Description of changes:

Behavior added in commit 89e1fd0d was accidentally removed in f3e49b01. This commit replaces that code.

Call-outs:

  • n/a

Testing:

  • CI tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Behavior added in commit [`89e1fd0d`][1] was accidentally removed in
[`f3e49b01`][2]. This commit replaces that code.

[1]: aws@89e1fd0
[2]: aws@f3e49b0
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7779551) 76.72% compared to head (e028863) 76.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1357      +/-   ##
==========================================
+ Coverage   76.72%   76.74%   +0.01%     
==========================================
  Files         422      422              
  Lines       71190    71196       +6     
==========================================
+ Hits        54621    54639      +18     
+ Misses      16569    16557      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review December 13, 2023 22:43
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner December 13, 2023 22:43
@WillChilds-Klein WillChilds-Klein enabled auto-merge (squash) December 13, 2023 23:59
@WillChilds-Klein WillChilds-Klein merged commit 2ac7aef into aws:main Dec 14, 2023
17 checks passed
@WillChilds-Klein WillChilds-Klein deleted the libssl-replace-0-byte-io branch December 14, 2023 15:46
@skmcgrail skmcgrail mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants