Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FIPS shared builds on x86 platform. #123

Merged
merged 5 commits into from
Apr 6, 2021

Conversation

bryce-shang
Copy link
Contributor

Issues:

Addresses CryptoAlg-723

Description of changes:

This PR added FIPS shared builds on x86 platform.

Some minor changes of this PR include

  • Add comment for AL2 Clang FIPS build.
  • Validate GitHub access token when building Docker image.
  • Check FIPS mode by running tool/bssl isfips.

Call-outs:

  • FIPS Shared release build on x86 Gcc-7x is disabled. I will make additional investigation on the build error.

Testing:

  • CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@nebeid nebeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Bryce. Did you encounter the error I mentioned in CryptoAlg-723?

tests/ci/common_posix_setup.sh Show resolved Hide resolved
tests/ci/run_fips_tests.sh Show resolved Hide resolved
@bryce-shang
Copy link
Contributor Author

bryce-shang commented Apr 6, 2021

Thank you, Bryce. Did you encounter the error I mentioned in CryptoAlg-723?

No, I think the error may relate to

  • FIPS_SHARED=1 is not the build interface but an intermediate value. FIPS=1 should be used.

I encountered some delocate issue when I investigated FIPS build on ARM. But the build succeeded after I changed compiler from Clang-10 to Clang-7. Maybe Clang-10 compiles c code with new assembly syntax which cannot be parsed by the delocate.go.

@bryce-shang bryce-shang merged commit 7095a4b into aws:main Apr 6, 2021
@bryce-shang bryce-shang deleted the fips-x86-shared-build branch May 12, 2021 17:13
WillChilds-Klein pushed a commit to WillChilds-Klein/aws-lc that referenced this pull request Mar 9, 2022
Do not modify output when Cipher.doFinal fails
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Jul 22, 2024
Complete improvements to Weierstrass point additions
s2n-bignum original commit: awslabs/s2n-bignum@b9266e7
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 18, 2024
Complete improvements to Weierstrass point additions
s2n-bignum original commit: awslabs/s2n-bignum@b9266e7
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 18, 2024
Complete improvements to Weierstrass point additions
s2n-bignum original commit: awslabs/s2n-bignum@b9266e7

s2n-bignum original commit: awslabs/s2n-bignum@7b4a690
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 19, 2024
Complete improvements to Weierstrass point additions
s2n-bignum original commit: awslabs/s2n-bignum@b9266e7
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Dec 5, 2024
Complete improvements to Weierstrass point additions
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Dec 10, 2024
Complete improvements to Weierstrass point additions
s2n-bignum original commit: awslabs/s2n-bignum@b9266e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants