Add Support for / in handler name #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlzogh
approved these changes
Jun 25, 2021
| ) | ||
| response_handler() | ||
|
|
||
| def test_get_event_handler_doent_throw_build_in_module_name(self): |
There was a problem hiding this comment.
nit: typo doent -> doesnt
SukanyaHanumanthu
approved these changes
Jun 25, 2021
keshayad
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43
Support for / in handler name
Added test for the same
Added the review comments from PR Add Support for / in handler name #44
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.