Add requestId in error response #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preearor
changed the title
carlzogh
approved these changes
Jun 16, 2021
zsombor-balogh
approved these changes
Jun 16, 2021
Comment on lines
+1012
to
+1016
| frame_type = int.from_bytes(content[:4], "big") | ||
| self.assertEqual(frame_type, 0xA55A0001) | ||
|
|
||
| length = int.from_bytes(content[4:8], "big") | ||
| self.assertEqual(length, len(expected_logged_error)) |
There was a problem hiding this comment.
nit: there are separate tests to ensure the framing is correct, these assertions are redundant here
| result = { | ||
| "errorMessage": error_message if error_message else "", | ||
| "errorType": error_type if error_type else "", | ||
| "requestId": invoke_id if invoke_id is not None else "", |
There was a problem hiding this comment.
nit: this can be simplified:
"requestId": invoke_id if invoke_id else "",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer can search for requestId in LogResults, and cloudwatch but getting it returned in error response relieve their pain for searching
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.