-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Queue representation in ConnectEvent.java #482
base: main
Are you sure you want to change the base?
Conversation
AWS Connect defines the Queue as an object, not a string. The object contains ARN and name (as well as address and type). I am fixing the Event model so that it correctly deserialised. For reference, I have followed the model used by the Go implementation here: https://github.com/aws/aws-lambda-go/blame/main/events/connect.go
would you mind updating https://github.com/aws/aws-lambda-java-libs/blob/main/aws-lambda-java-tests/src/test/resources/connect_event.json and Line 273 in 5c53c44
|
Thanks for taking a look @smirnoal - apologies for missing the tests, I'd just opened that one file in the online editor and hadn't thought to check. I've updated accordingly now, appreciate if you could take another look. |
While we're changing the event, I think it would be wise to include all the changes to Queue.
|
@jonnysw would you take a look at the failed test? |
Hi @smirnoal my apologies, I've recently changed job and had forgotten about this. Will try to spend some time on it over the next week if I can. |
Hi Team, |
Issue #, if available:
NA
Description of changes:
At present, when trying to invoke a lambda that uses a ConnectEvent in its handler, it will fail with:
I am fixing the Event model so that it can be correctly deserialised.
AWS Connect defines the Queue as an object when invoking a lambda, not a string. The object contains ARN and Name (as well as Address and Type). See here for the full model:
https://docs.aws.amazon.com/connect/latest/adminguide/connect-lambda-functions.html
For reference, I have followed the model used by the Go implementation here: https://github.com/aws/aws-lambda-go/blame/main/events/connect.go
Target (OCI, Managed Runtime, both):
both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.