add authorizer context to APIGatewayProxyRequestEvent #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoffatt
reviewed
Jan 19, 2018
| return authorizer; | ||
| } | ||
|
|
||
| public void setAuthorizer(Map<String, String> authorizer) { |
There was a problem hiding this comment.
From aws/aws-lambda-dotnet#98, "authorizer" may contain more than just strings. To be truly generic, it might be that a APIGatewayAuthorizedProxyEvent<T> needs to be added.
|
@oharaandrew314 |
|
I have re-opened this PR as #77. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields in the authorizer object can change depending on what is returned by the authorizer function context. While
principalIdwill always be there, the rest of the fields can vary. Thus aMapmust be used.