-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: V1 and V2 of the API Gateway custom authorizer event and the si… #166
Conversation
…mplified IAM policy.
private String requestId; | ||
private String routeKey; | ||
private String stage; | ||
private String time; // "time": "12/Mar/2020:19:03:58 +0000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be an object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be better off as a ZonedDateTime
object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, ZonedDateTime
(de)serialization is not currently supported in the Java runtimes, either String
or org.joda.time.DateTime
(currently preferred) should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is possible to write a custom StdDeserializer
to achieve this, but we dont want to do that ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately registering a custom mapper in this library is not currently supported by the Java runtime and this is probably the best solution we can implement at this time IMHO
Tested |
…mplified IAM policy.
Thanks a lot for your continued contributions @msailes! 😃 |
…mplified IAM policy.
Issue #, if available:
n/a
Description of changes:
Pojos for the API Gateway custom authorizers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.