Adding authorizer field to collect context properties from authorizer #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2019
|
Let me know if we need to keep non-String types specifically for Authorizer context. I'll change it to |
|
+1 to trying to get this added. For people trying to use this library for Cognito User Pool integration (or other types of authorization), it's a non-starter. |
|
@bmoffatt could you please take a look & share your thoughts? Thanks |
|
@avanathan |
|
@bmoffatt I've switched it to |
|
Thanks! |
|
@bmoffatt When do we usually cut a release? |
raupachz
pushed a commit
to raupachz/aws-lambda-java-libs
that referenced
this pull request
Dec 1, 2020
…aws#77) * Adding authorizer field to collect context properites from authorizer * Updating toString() method * Adding authorizer to equals() & hashCode() * Moving authorizer under ProxyRequestContext * Switching to Map<String, Object> for authorizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Reopening: #39
Description of changes:
Adding a map to hold context properties from authorizer. cc: @bmoffatt @oharaandrew314 @miere . This PR was originally submitted by @oharaandrew314 and got closed based on a review comment for using
Stringkey/values. All other collection fields in this class useMap<String, String>. Not sure why we need to worry about other types (nonString) just for this. We could keep this in the short term until we find a long term solution. Libraries for rest of the programming languages like golang & .Net already support this. Thanks for your support.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.