Fix GetJobLogs and e2e-neuron binary not exits issue. #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
GetJobLogs
was using the same context as the main context. This would cause if time out happens the tests will not print out the logs from the tests. Let theGetJobLogs
usecontext.Background()
to let it always prints out the logs.e2e-neuron
test binary to the kubetest2 dockerfile.Test:
Tested it will always print out the logs even timeout reached
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.