Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for unit test and delete the duplicated docker file. #457

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

weicongw
Copy link
Contributor

@weicongw weicongw commented Jul 10, 2024

Issue #, if available:

Description of changes:
Follow-up on the previous PR: #456. Add a test case for the unit test and remove the duplicated Dockerfile. The Nvidia GPU tests will use the same image for all tests (both single-node and multi-node).

Testing:

go test -v . -args -nvidiaTestImage  public.ecr.aws/o5d5x8n6/weicongw:nvidia -feature unit-test -efaEnabled=true
W0710 18:30:20.557612   14459 warnings.go:70] spec.template.spec.affinity.nodeAffinity.requiredDuringSchedulingIgnoredDuringExecution.nodeSelectorTerms[0].matchExpressions[0].key: beta.kubernetes.io/instance-type is deprecated since v1.17; use "node.kubernetes.io/instance-type" instead
W0710 18:30:20.557667   14459 warnings.go:70] spec.template.metadata.annotations[scheduler.alpha.kubernetes.io/critical-pod]: non-functional in v1.16+; use the "priorityClassName" field instead
2024/07/10 18:30:25 No node type specified. Using the node type p3.2xlarge in the node groups.
=== RUN   TestMPIJobPytorchTraining
=== RUN   TestMPIJobPytorchTraining/single-node
    env.go:438: Skipping feature "single-node": name not matched
=== RUN   TestMPIJobPytorchTraining/multi-node
    env.go:438: Skipping feature "multi-node": name not matched
--- PASS: TestMPIJobPytorchTraining (0.00s)
    --- SKIP: TestMPIJobPytorchTraining/single-node (0.00s)
    --- SKIP: TestMPIJobPytorchTraining/multi-node (0.00s)
=== RUN   TestSingleNodeUnitTest
=== RUN   TestSingleNodeUnitTest/unit-test
=== RUN   TestSingleNodeUnitTest/unit-test/Unit_test_Job_succeeds
--- PASS: TestSingleNodeUnitTest (25.48s)
    --- PASS: TestSingleNodeUnitTest/unit-test (25.48s)
        --- PASS: TestSingleNodeUnitTest/unit-test/Unit_test_Job_succeeds (25.07s)
PASS
ok      github.com/aws/aws-k8s-tester/e2e2/test/cases/nvidia    45.036s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@weicongw weicongw marked this pull request as ready for review July 10, 2024 22:40
Copy link
Contributor

@ndbaker1 ndbaker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one doc update

e2e2/test/cases/neuron/neuron_test.go Outdated Show resolved Hide resolved
@cartermckinnon cartermckinnon merged commit c6f75cf into aws:main Jul 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants