add windows kube-proxy role to aws-auth map #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Windows ASG are created with the node Instance role without having the
eks:kube-proxy-windows
because of which connectivity to any service would fail. The aws-auth map should also have roleeks:kube-proxy-windows
. SeeDescription of changes:
If Windows AMI is present add the additional
eks:kube-proxy-windows
to the Node Instnace role. It work for Linux because kube-proxy runs as DaemonSet, whereas kube-proxy runs as a service on Windows OS, hence the additional permissions.Future Improvements
Since the Windows and Linux ASG are created with the same role, the Linux node will get additional RBAC permissions that's required by the Windows Node. In future we can create separate role for Windows and Linux and add only required policy.
Testing Results
Linux only ASG
Linux and Windows ASG
Checking Service connectivity from Windows Node
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.