-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update vendor, ignore some errors in eks delete #191
Conversation
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Thanks for doing this Gyuho! I ran this against an aws-k8s-tester cluster that failed to delete its vpc and role stacks and it successfully cleaned up those two stacks. I checked out the config from S3 on a different machine than what executed the original test.
It looks like the overall command fails due to the missing file even though everything is successfully cleaned up. Is it possible for the command to have a successful exit in this case? I also ran into an issue building the Mac binaries:
Is this an issue with my local environment or is something broken? |
Signed-off-by: Gyuho Lee <[email protected]>
@natherz97 Try
The build script builds both linux and darwin by default. Never mind, getting same error. |
ory/dockertest#212 (comment) === Building target=aws-k8s-tester, os=darwin === github.com/docker/docker/pkg/term vendor/github.com/docker/docker/pkg/term/tc.go:13:28: undefined: unix.SYS_IOCTL vendor/github.com/docker/docker/pkg/term/tc.go:18:28: undefined: unix.SYS_IOCTL vendor/github.com/docker/docker/pkg/term/termios_bsd.go:24:31: undefined: unix.SYS_IOCTL vendor/github.com/docker/docker/pkg/term/termios_bsd.go:37:31: undefined: unix.SYS_IOCTL Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Ran the command again and deleting had a successful status after cleaning up leftover role and vpc stacks:
Trying against a test which has a vpc stack stuck in DELETED_FAILED:
|
* *: update CHANGELOG, vendor Signed-off-by: Gyuho Lee <[email protected]> * eks/conformance: fmt Signed-off-by: Gyuho Lee <[email protected]> * eksconfig: ignore/log error in validate config file sync Signed-off-by: Gyuho Lee <[email protected]> * pkg/logutil: ignore writer error for log file Signed-off-by: Gyuho Lee <[email protected]> * CHANGELOG: update Signed-off-by: Gyuho Lee <[email protected]> * eks: ignore more sync errors Signed-off-by: Gyuho Lee <[email protected]> * eks: do no fail delete on missing file Signed-off-by: Gyuho Lee <[email protected]> * *: fix darwin build with docker dependency ory/dockertest#212 (comment) === Building target=aws-k8s-tester, os=darwin === github.com/docker/docker/pkg/term vendor/github.com/docker/docker/pkg/term/tc.go:13:28: undefined: unix.SYS_IOCTL vendor/github.com/docker/docker/pkg/term/tc.go:18:28: undefined: unix.SYS_IOCTL vendor/github.com/docker/docker/pkg/term/termios_bsd.go:24:31: undefined: unix.SYS_IOCTL vendor/github.com/docker/docker/pkg/term/termios_bsd.go:37:31: undefined: unix.SYS_IOCTL Signed-off-by: Gyuho Lee <[email protected]> * vendor: update golang/sys/unix Signed-off-by: Gyuho Lee <[email protected]> * CHANGELOG: update Signed-off-by: Gyuho Lee <[email protected]> * eks: ignore Sync errors Signed-off-by: Gyuho Lee <[email protected]>
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.