Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing additional args to worker bootstrap script. Update NG CFN for special regions. #188

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

cmdallas
Copy link
Contributor

Issue #, if available:

Description of changes:
Exposes configuration for additional bootstrap args and makes region specific adjustments required for special regions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cmdallas cmdallas requested a review from gyuho November 20, 2020 01:13
eks/ng/nodes.go Outdated Show resolved Hide resolved
@gyuho
Copy link
Contributor

gyuho commented Nov 20, 2020

Can we also run https://github.com/aws/aws-k8s-tester/blob/master/hack/eksconfig.gen.sh

./hack/eksconfig.gen.sh

@cmdallas
Copy link
Contributor Author

'aws-k8s-tester eks create config --path "./eksconfig/default.yaml"' success

Looking for anything in particular?

@gyuho gyuho merged commit cf3f56e into aws:master Nov 20, 2020
mmerkes pushed a commit to mmerkes/aws-k8s-tester that referenced this pull request Dec 21, 2020
… CFN for special regions. (aws#188)

* *: support passing additional args to worker bootstrap script

* (ng): update cfn init to support special regions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants