Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eks/cluster: fix OIDC CA thumbprint fetch #172

Merged
merged 2 commits into from
Sep 28, 2020
Merged

eks/cluster: fix OIDC CA thumbprint fetch #172

merged 2 commits into from
Sep 28, 2020

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 26, 2020

HTTP GET failure due to bad packet or packet loss should be retried.

Fix the following panic:

{"level":"info","ts":"2020-09-25T23:43:56.457-0700","caller":"cluster/cluster.go:700","msg":"updating host with port :443","host":"..."}
{"level":"info","ts":"2020-09-25T23:43:56.457-0700","caller":"cluster/cluster.go:711","msg":"fetching OIDC CA thumbprint","url":"https://...:443/test/id/78FD753967D735CEFC309F15590F617F"}
{"level":"warn","ts":"2020-09-25T23:44:38.734-0700","caller":"cluster/cluster.go:720","msg":"failed to fetch OIDC CA thumbprint","url":"https://...:443/test/id/78FD753967D735CEFC309F15590F617F","error":"Get \"https://...:443/test/id/78FD753967D735CEFC309F15590F617F\": local error: tls: bad record MAC"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x221029b]

goroutine 221 [running]:
github.com/aws/aws-k8s-tester/eks/cluster.(*tester).updateClusterStatus(0xc00074d4a0, 0xc00100abd0, 0x0, 0x0, 0x507acd1, 0x6)
        aws-k8s-tester/eks/cluster/cluster.go:725 +0xd5b
github.com/aws/aws-k8s-tester/eks/cluster.(*tester).createEKS(0xc00074d4a0, 0x0, 0x0)
        aws-k8s-tester/eks/cluster/cluster.go:509 +0x1688
github.com/aws/aws-k8s-tester/eks/cluster.(*tester).Create(0xc00074d4a0, 0x527b490, 0xc000623a00)
        aws-k8s-tester/eks/cluster/cluster.go:105 +0x1de
github.com/aws/aws-k8s-tester/eks.catchInterrupt.func1(0xc000661c80, 0xc001003e80)
        aws-k8s-tester/eks/eks.go:1682 +0x27
created by github.com/aws/aws-k8s-tester/eks.catchInterrupt
        aws-k8s-tester/eks/eks.go:1681 +0x7a

Fix the following panic:

{"level":"info","ts":"2020-09-25T23:43:56.457-0700","caller":"cluster/cluster.go:700","msg":"updating host with port :443","host":"..."}
{"level":"info","ts":"2020-09-25T23:43:56.457-0700","caller":"cluster/cluster.go:711","msg":"fetching OIDC CA thumbprint","url":"https://...:443/test/id/78FD753967D735CEFC309F15590F617F"}
{"level":"warn","ts":"2020-09-25T23:44:38.734-0700","caller":"cluster/cluster.go:720","msg":"failed to fetch OIDC CA thumbprint","url":"https://...:443/test/id/78FD753967D735CEFC309F15590F617F","error":"Get \"https://...:443/test/id/78FD753967D735CEFC309F15590F617F\": local error: tls: bad record MAC"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x221029b]

goroutine 221 [running]:
github.com/aws/aws-k8s-tester/eks/cluster.(*tester).updateClusterStatus(0xc00074d4a0, 0xc00100abd0, 0x0, 0x0, 0x507acd1, 0x6)
        aws-k8s-tester/eks/cluster/cluster.go:725 +0xd5b
github.com/aws/aws-k8s-tester/eks/cluster.(*tester).createEKS(0xc00074d4a0, 0x0, 0x0)
        aws-k8s-tester/eks/cluster/cluster.go:509 +0x1688
github.com/aws/aws-k8s-tester/eks/cluster.(*tester).Create(0xc00074d4a0, 0x527b490, 0xc000623a00)
        aws-k8s-tester/eks/cluster/cluster.go:105 +0x1de
github.com/aws/aws-k8s-tester/eks.catchInterrupt.func1(0xc000661c80, 0xc001003e80)
        aws-k8s-tester/eks/eks.go:1682 +0x27
created by github.com/aws/aws-k8s-tester/eks.catchInterrupt
        aws-k8s-tester/eks/eks.go:1681 +0x7a

Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Copy link
Contributor

@PatrickXYS PatrickXYS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho merged commit 8302fde into aws:master Sep 28, 2020
@gyuho gyuho deleted the patch branch September 28, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants