Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handwritten echo RPC and tests #349

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Handwritten echo RPC and tests #349

merged 4 commits into from
Apr 11, 2023

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Apr 5, 2023

Part two of the eventstream RPC work. Contains a hand-written echo client intended to be the model for Greengrass RPC code generation (the next step). Includes a variety of tests exercising success and failure pathways.

Will not build until the CRT gets a release that includes awslabs/aws-crt-nodejs#439

Does not include doc comments because I'm not writing doc comments for something that will be replaced by generated code that includes doc comments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lib/echo_rpc/echo_rpc.ts Outdated Show resolved Hide resolved
lib/echo_rpc/echo_rpc.spec.ts Outdated Show resolved Hide resolved
lib/echo_rpc/echo_rpc.spec.ts Outdated Show resolved Hide resolved
lib/echo_rpc/echo_rpc.spec.ts Outdated Show resolved Hide resolved
lib/echo_rpc/echo_rpc.ts Outdated Show resolved Hide resolved
lib/echo_rpc/model.ts Outdated Show resolved Hide resolved
@bretambrose bretambrose merged commit bb75c80 into EventstreamRPC Apr 11, 2023
@bretambrose bretambrose deleted the EchoRPC branch April 11, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants