Added additional input parameter pThingName to aws_iot_shadow_registe…

[nikitanerkar]

…r_delta api.

With this implentation, flexibility is given to the application developer to
accept thingname from the user during initial setup and then configure it by
passing it to the shadow subscribe API.

Problem: Thingname used in shadow subscribe API is hardcoded compile time using
macro AWS_IOT_MY_THING_NAME which reduces flexibilty.
Also all other shadow APIs have thingname as the input parameter and can be
configured compile time.

Signed-off-by: Nikita Nerkar [email protected]

[bhadrip]

Hi @nikitanerkar ,

Thanks for submitting the change.

There are two things,

1. Thing Name needs to configurable at boot - up
2. Ability to listen on (register for ) delta topic for multiple thing names

We consciously decided, not to support the second option to keep the size of the SDK small. Most common use case for a device is to listen to its own delta topic. But there are applications(Mobile or Web ) that might have to listen to the delta topic of other Things. The other actions like Update, Get can be done for any thing name. It would be great to learn more about your use case.

I agree that first point needs to be addressed, we will add the feature of configuring the thing name of delta topic at boot-up in the next release.

Thanks
Bhadri

[gthole]

I would prefer to see the aws_iot_shadow_register_delta respect the pMyThingName supplied on the connection ShadowParameters. That attribute currently seems to be ignored (rendering it a NOP), which is quite confusing. Is this the plan for the next release?

Without that change (currently aws_iot_shadow_register_delta listens to the topic as set by a compiler definition), I'd have to manually compile the binaries for each device individually, rather than compiling and distributing a single binary.

Thanks!

[chaurah]

Hi @gthole,
As of v2.0.0 of the SDK, the pMyThingName supplied with the Shadow Parameters is used internally to register deltas. Please accept my apologies for the delay in updating here. Could you check if the issue you were having is resolved?

Rahul