Reconnect handling #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report out when the mBedTLS library reports that the network layer has been disconnected out from the iot_tls_write(...) and iot_tls_read(...) calls. Signed-off-by: Tim Nordell <[email protected]>
The various instances of utilizing the iot_tls_read(...) and iot_tls_write(...) calls should all inform their users of the errors these functions can emit. This helps for proper management of interface errors, such as a network disconnection.
…loop Move the _aws_iot_mqtt_handle_disconnect(...) call to cover both the aws_iot_mqtt_internal_cycle_read(...) call and the _aws_iot_mqtt_keep_alive(...) call.
This commit moves the disconnect handler into a central code location for a future patch in this series that also invokes the handler from the send packet path (and not just the receive packet path).
The _aws_iot_mqtt_internal_yield(...) function has some common disconnect handling code in it yet. Move this to its own function, and call this instead of the direct disconnect method.
Use the new common internal API for handling disconnects to handle the disconnect from a publish call.
|
This pull request will be included in the next release of the SDK. Further discussion on the corresponding issue here - #33 |
|
Fixed in v2.1.1 of the SDK. Closing. |
tgsong
pushed a commit
to tgsong/aws-iot-device-sdk-embedded-C
that referenced
this pull request
Nov 13, 2020
OTA Over HTTP demo implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #33.