Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test bugs reported by Coverity. #167

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Fix integration test bugs reported by Coverity. #167

merged 1 commit into from
Apr 23, 2018

Conversation

gordonwang0
Copy link
Contributor

No description provided.

@@ -262,7 +264,7 @@ int aws_iot_mqtt_tests_multi_threading_validation() {
} while(SUCCESS != rc && connectCounter < CONNECT_MAX_ATTEMPT_COUNT);

if(SUCCESS == rc) {
printf("\n## Connect Success. Time sec: %d, usec: %d\n", connectTime.tv_sec, connectTime.tv_usec);
printf("\n## Connect Success.\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see connectTime used anywhere? It's declared on line 206, but not used anywhere until it's printed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! that's correct, good finding

@huguesBouvier huguesBouvier merged commit 4ff32f7 into aws:master Apr 23, 2018
@gordonwang0 gordonwang0 deleted the coverity_fixes branch April 24, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants