Bump to 2.23.2 #319
Merged
Bump to 2.23.2 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Drew Zhang <[email protected]>
matthewfala
reviewed
Mar 24, 2022
| 2.23.2 |
There was a problem hiding this comment.
Isn't this a major version because it includes an enhancement? The enhancement is minor, so maybe that's why you are making this a minor version bump. Minor bump makes sense to me, just something to think about.
There was a problem hiding this comment.
No I don't think it's a major version change. We don't see much change between last version and this version. So just a minor change. I would expect major version change like multiple line support feature or version 1.19 or at least several important bug fix or enhancement PRs.
matthewfala
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Drew Zhang [email protected]
Bump to 2.23.2 version
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.