chore: Bump fmt-maven-plugin from 2.10 to 2.11 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Bumps [fmt-maven-plugin](https://github.com/coveo/fmt-maven-plugin) from 2.10 to 2.11. - [Release notes](https://github.com/coveo/fmt-maven-plugin/releases) - [Commits](https://github.com/coveo/fmt-maven-plugin/commits) --- updated-dependencies: - dependency-name: com.coveo:fmt-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/maven/com.coveo-fmt-maven-plugin-2.11
branch
from
9b2e673
to
cbdcd6f
Compare
|
Noticed this while scanning for breaking changes/a change log (why can I not find Maven repo change logs?): "Starting from version 1.8, Google Java Formatter requires Java 11 to run. Incidently, all versions of this plugin starting from 2.10 inclusively also require this Java version to properly function. The 2.9.x release branch is the most up-to-date version that still runs on Java 8." -- fmt-maven-plugin: f89f8a3 We support Java 8. We may want to downgrade |
texastony
reviewed
Jul 9, 2021
We support java8 and greater. fmt-maven-plugin 2.9.x supports java8. fmt-maven-plugin >= 2.10 needs java11 and up.
texastony
changed the title
This comment has been minimized.
This comment has been minimized.
|
I should have looked into the pom.xml before downgrading to 2.9.1. My bad. Let's see if I can undo my foolishness. |
This reverts commit 5c4a4e6 We only use the fmt-maven-plugin on java11 targets
texastony
changed the title
texastony
approved these changes
Jul 9, 2021
dependabot
bot
deleted the
dependabot/maven/com.coveo-fmt-maven-plugin-2.11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps fmt-maven-plugin from 2.10 to 2.11.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)