Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI examples for ds-data, ecr-public #9015

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

elysahall
Copy link
Collaborator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elysahall elysahall added the documentation This is a problem with documentation. label Oct 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.08%. Comparing base (909bb35) to head (056e34e).
Report is 36 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #9015   +/-   ##
=======================================
  Coverage     0.08%   0.08%           
=======================================
  Files          210     210           
  Lines        16984   16984           
=======================================
  Hits            14      14           
  Misses       16970   16970           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elysahall elysahall added the pr:needs-review This PR needs a review from a Member. label Nov 19, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example is quite long, making the page larger and harder for users to scroll through.

Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just see one thing remaining!

awscli/examples/ecr-public/put-registry-catalog-data.rst Outdated Show resolved Hide resolved
@kdaily kdaily added pr:ready-to-merge This PR is ready to be merged. pr:work-in-progress This PR is a draft and needs further work. and removed pr:needs-review This PR needs a review from a Member. pr:ready-to-merge This PR is ready to be merged. labels Jan 22, 2025
Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdaily kdaily added pr:ready-to-merge This PR is ready to be merged. and removed pr:work-in-progress This PR is a draft and needs further work. labels Jan 22, 2025
@kdaily kdaily merged commit d2cd819 into aws:develop Jan 23, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:ready-to-merge This PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants