Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UnhealthyNodeReplacement to CLI #8563

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

jonathan343
Copy link
Contributor

add UnhealthyNodeReplacement to CLI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 0.08%. Comparing base (23428bb) to head (d652fbc).
Report is 75 commits behind head on develop.

Files Patch % Lines
...scli/customizations/emr/modifyclusterattributes.py 0.00% 7 Missing ⚠️
awscli/customizations/emr/createcluster.py 0.00% 2 Missing ⚠️
awscli/customizations/emr/emr.py 0.00% 1 Missing ⚠️
awscli/customizations/emr/helptext.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #8563      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          208     208              
  Lines        16707   16717      +10     
==========================================
  Hits            14      14              
- Misses       16693   16703      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathan343 jonathan343 requested a review from kyleknap March 6, 2024 23:48
Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just had some comments about the tests

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@jonathan343 jonathan343 merged commit a2e6b23 into aws:develop Mar 7, 2024
30 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Mar 7, 2024
* release-1.32.58:
  Bumping version to 1.32.58
  Update changelog based on model updates
  add UnhealthyNodeReplacement to CLI (#8563)
jonathan343 added a commit to jonathan343/aws-cli that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants