-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UnhealthyNodeReplacement to CLI #8563
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8563 +/- ##
==========================================
- Coverage 0.08% 0.08% -0.01%
==========================================
Files 208 208
Lines 16707 16717 +10
==========================================
Hits 14 14
- Misses 16693 16703 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just had some comments about the tests
tests/unit/customizations/emr/test_set_unhealthy_node_replacement.py
Outdated
Show resolved
Hide resolved
tests/unit/customizations/emr/test_set_unhealthy_node_replacement.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚢
* release-1.32.58: Bumping version to 1.32.58 Update changelog based on model updates add UnhealthyNodeReplacement to CLI (#8563)
This reverts commit a2e6b23.
add UnhealthyNodeReplacement to CLI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.