Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS::Serverless::StateMachine resource to cloudformation package command #5576

Merged

Conversation

joel-aws
Copy link
Contributor

Issue #: #5480

Description of changes:

AWS SAM added support for AWS Step Functions. One of the properties is DefinitionUri, which is not currently exported as an artifact when calling aws cloudformation package.

This is based on PR #5222.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #5576 (042929e) into develop (23e4b4f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #5576   +/-   ##
========================================
  Coverage    92.87%   92.88%           
========================================
  Files          204      204           
  Lines        16329    16336    +7     
========================================
+ Hits         15166    15173    +7     
  Misses        1163     1163           
Impacted Files Coverage Δ
...customizations/cloudformation/artifact_exporter.py 98.68% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4b4f...042929e. Read the comment docs.

@joel-aws joel-aws changed the title Support exporting DefinitionUri in AWS::Serverless::StateMachine Add AWS::Serverless::StateMachine resource to cloudformation package command Oct 7, 2020
@aczire
Copy link

aczire commented Feb 9, 2021

Still waiting for DefinitionUri support for AWS::Serverless::StateMachine in aws cloudformation package. Any update?

@joel-aws
Copy link
Contributor Author

joel-aws commented Feb 9, 2021

Looks like this issue was never assigned.

@stilvoid @kdaily -- would you be able to help getting this reviewed?

@justindho justindho force-pushed the package-serverless-states-definitionuri branch from bf5be97 to 042929e Compare May 31, 2022 23:04
Copy link
Contributor

@justindho justindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joel-aws!

@justindho justindho merged commit 9b940e8 into aws:develop May 31, 2022
@justindho justindho added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label May 31, 2022
@justindho justindho added released and removed pending-release This issue will be fixed by an approved PR that hasn't been released yet. labels Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

AWS::Serverless::StateMachine DefinitionUri support for cloudformation package
4 participants