Use IMDSv2 for autodiscovering EC2 region #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/functional/test_clidriver.py
Outdated
| @@ -27,6 +27,17 @@ | |||
| from awscli.clidriver import create_clidriver | |||
|
|
|||
|
|
|||
| class RegionCapture(object): | |||
| def __init__(self): | |||
| self._region = None | |||
There was a problem hiding this comment.
Make this public since we are accessing it from outside the class (in the test).
vz10
force-pushed
the
imdsv2_for_ec2_region_detect
branch
from
913bf46 to
cd008a7
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #5207 +/- ##
=======================================
Coverage 94.39% 94.39%
=======================================
Files 232 232
Lines 17564 17565 +1
=======================================
+ Hits 16579 16580 +1
Misses 985 985
Continue to review full report at Codecov.
|
stealthycoin
approved these changes
May 18, 2020
This was referenced Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4976
Description of changes:
Use IMDSv2, if it supported by instance, for auto-discovering EC2 region
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.