-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing metadata causing dependency resolution slowdown #5701
Comments
Hi @l0b0, Thanks for the report. I'm following up on the issue at Poetry. |
Looks like to me that we would have to specify dependencies in a |
@kdaily FWIW, I did some research into how to expose dependencies via the package metadata to the PyPi JSON API, and best I can tell, the metadata missing is due to using an old client to publish the package to PyPi. I can't find anything indicating it would be necessary to use pyproject.toml. According to this issue/comment, the dependency info is stored in
|
Hey @l0b0, thanks for the deep dive! We are specifying this info in our setup.cfg and it's available in the wheels we distribute. I think you've nailed the issue though, the upload process appears to be uploading our sdist (.tar.gz) distribution first which for some reason isn't including this metadata. We'll either need to look at flipping the order of which artifact gets uploaded to PyPI first, or get the metadata included correctly in our sdist build process. |
Bless you for finding this. I tried to wander down this path but didn't get to the definitive pointer you did. Great work! |
Good news! We've recently refactored a large portion of our release process which made getting this fix out possible. We've published today's releases using it and the metadata is now available for awscli, boto3, and botocore. s3transfer doesn't release on a regular cadence, but it will also see the updates automatically in its next release. Please let us know if you're still seeing any issues, otherwise we'll plan to close this soon. Thanks! |
Resolving since the metadata has been available for the last week and seems to be working correctly. Please let us know if you encounter any more issues. |
|
failed b/c dependencies aren't available via JSON API like in aws/aws-cli#5701
Confirm by changing [ ] to [x] below to ensure that it's a bug:
Describe the bug
From a Poetry issue:
SDK version number N/A
Platform/OS/Hardware/Device
What are you running the cli on? Ubuntu 20.04
To Reproduce (observed behavior)
awscli = "*"
to Poetry dependenciespoetry update
Expected behavior
Dependencies should resolve in at most a couple seconds.
The text was updated successfully, but these errors were encountered: