-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws ecr get-login broken in latest rc build #2676
Comments
You will need to supply the |
Also, please see this forum post for more context about this https://forums.aws.amazon.com/ann.jspa?annID=4656 |
Why is this marked as "closing-soon-if-no-response"? The |
The flag is |
@ottumm We can't change our current behavior or we'll break customers locked to older versions of docker. The compromise is to have the flag which will allow customers who upgrade to unblock themselves. |
Rather than adding a flag why not detect the docker version. It seems that the AWS client has enough information to decide whether or not to include the -e in the login command rather than generating an invalid command. |
Absolutely agree with @Clecompt. There are environments (e.g. Travis) where the Docker version is not under the user's control. Detecting the Docker version and emitting the appropriate command seems like the right thing to do here. |
Because detecting the docker version and testing that on every possible system configuration people are using in the CLI in is not feasible and very brittle even if we could get it to work. Even if we could get this to work that makes the assumption that the login command is being run on the same machine in the environment where we detected the docker version. People have very complicated build systems spread out over multiple machines/images/environments so that is not an acceptable assumption to make. You can control the docker version in travis by the way using the before_install key. |
@stealthycoin Has this issue been fixed? Agreed that detecting the docker version is no good. The email option has been removed from Docker so having some sort of |
@JordonPhillips I am adding --no-include-email it gives me Unknown Options. According aws docs, Updated to latest version still I get the same Unknown Options. |
@vanaparth had the same issue, updating aws cli tools with |
I tried the command which you mentioned still getting the same problem. Is there any other way we can clear this issue. @igarcez |
@igarcez Here is the other way to login. I have a workaround |
Still broken. Installed the latest version of AWS CLI. aws ecr get-login --region <my-region> --no-include-email returns Unknown options: --no-include-email |
Still an issue!
yields:
$ aws --version
aws-cli/1.11.13 Python/3.5.2 Linux/4.4.0-1022-aws botocore/1.4.70 |
@zeg-io you are actually using version |
@mmas why do you say he's using version |
@bbakersmith I had version |
@mmas odd. it doesn't for me. I just upgraded and get |
And the |
aws-cli/1.11.42 Python/2.7.10 Darwin/16.7.0 botocore/1.5.5 |
@ChrisRyuGS You need to upgrade. As I said a few comments up, it was added in 1.11.91 |
@bbakersmith Thank you. |
Hopefully this helps someone, as my aws --version was not changing (Ubuntu 16.04). Managed to resolve by using pip3 instead:
This may require you to install
|
For people coming from Google stuck here on old environments, there's an easy solution : eval $(aws ecr get-login --region eu-west-1 | sed 's/ \-e none//') |
Mine is strange, I got this error and guess what? I use amazon image This is my
|
The workaround for aws docker login error I use.
|
This status code usually indicates an unauthorized user. To fix this, we need to let our Code Build role be able to talk to ECR. To do this: Go to IAM and then attach a AmazonEC2ContainerRegistryPowerUser policy to your CodeBuild role. |
The text was updated successfully, but these errors were encountered: