Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify that breaking changes are for experimental APIs #9876

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 20, 2020

Change the "BREAKING CHANGES" header in the CHANGELOG to
"BREAKING CHANGES TO EXPERIMENTAL FEATURES" to make it sure that
stable features are not being broken.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Change the "BREAKING CHANGES" header in the CHANGELOG to
"BREAKING CHANGES TO EXPERIMENTAL FEATURES" to make it sure that
stable features are not being broken.
@rix0rrr rix0rrr requested a review from a team August 20, 2020 16:33
@rix0rrr rix0rrr self-assigned this Aug 20, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 20, 2020
Comment on lines +30 to +33
sed -i.tmp -e 's/BREAKING CHANGES$/BREAKING CHANGES TO EXPERIMENTAL FEATURES/' CHANGELOG.md
rm CHANGELOG.md.tmp
git add CHANGELOG.md
git commit --amend --no-edit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the alternative you considered before landing on sed?
making use of the lifecycle scripts? or other?

# I've gone diving through the code of `conventional-changelog` to see if there
# was a way to configure the string and ultimately I decided that a 'sed' was the simpler
# way to go.
sed -i.tmp -e 's/BREAKING CHANGES$/BREAKING CHANGES TO EXPERIMENTAL FEATURES/' CHANGELOG.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like experimental features rather than modules since we do have experimental tagged in classes, APIs, etc in stable modules.

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 51f409e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7ec598e into master Aug 20, 2020
@mergify mergify bot deleted the huijbers/breaking-experimental branch August 20, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants