-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lambda): move log retention custom resource to logs (#9671) #9808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like how this is coming out.
Just one comment about the logical ids below. It feels like we can go all the way and have no diffs in the generated stacks.
packages/@aws-cdk/aws-lambda/test/integ.log-retention.expected.json
Outdated
Show resolved
Hide resolved
Apologies for the multiple noisy commits, my local environment is having issues and I'm using CodeBuild for build verification. Changed the PR to draft mode till I get a proper working version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on getting the logical ids aligned. Just a couple of comments around union types and dependencies.
move LogRetention construct definition from lambda to logs while refactoring it so it does not depend on lambda constructs this required reimplementing the functionality provided by lambda.SingletonFunction using CfnResource keep declared classes/interfaces in lambda for compatability while marking them as deprecated they should be removed in an upcoming breaking change for their current customers in lambda and rds Fixes #9671
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All clear 🙌
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Great... looking forwards to this and the other changes we have lined up. |
I'm merging and resolving conflicts |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@nija-at seems like automerge didn’t kick off for some reason. It’s not clear to why that didn’t happen so appreciate letting me know if any further changes are needed on my end |
@Mergifyio refresh |
Command |
@humanzz - not sure what's going on with mergify there. I've manually merged this PR. |
@nija-at a little hiccup it seems but glad we got this merged. Thanks :-) |
move LogRetention construct definition from lambda to logs while refactoring it so it does not depend on lambda constructs
this required reimplementing the functionality provided by lambda.SingletonFunction using CfnResource
keep declared classes/interfaces in lambda for compatability while marking them as deprecated
they should be removed in an upcoming breaking change for their current customers in lambda and rds
remove rds dependency on lambda
Fixes #9671
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license