fix(aws-autoscaling): fix an AutoScalingGroup example in the README.md #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an AutoScalingGroup example in the README file.
eladb
reviewed
Oct 19, 2018
| import ec2 = require('@aws-cdk/aws-ec2'); | ||
|
|
||
| new ec2.AutoScalingGroup(stack, 'ASG', { | ||
| const vpc = new ec2.VpcNetwork(stack, 'VPC', { | ||
| maxAZs: 3 |
There was a problem hiding this comment.
No need to limit AZs in this example, just leave new ec2.VpcNetwork(stack, 'VPC')
There was a problem hiding this comment.
Ok, I will remove it.
| machineImage: new ec2.LinuxImage({ | ||
| 'us-east-1': 'ami-97785bed' | ||
| }) | ||
| machineImage: new ec2.AmazonLinuxImage() |
There was a problem hiding this comment.
Maybe a small comment explaining what this does
There was a problem hiding this comment.
Sure, I will add it. The AMI does not work for us-west-2. Specifically, I got the following message.
[AWS::AutoScaling::LaunchConfiguration] asgLaunchConfig37FDE42B AMI ami-97785bed is invalid: The image id '[ami-97785bed]' does not exist (Service: AmazonAutoScaling; Status Code: 400; Error Code: ValidationError; Request ID: d9ec164e-d35c-11e8-b28a-e7ee5dc94f2f)
Hence, I think that it is more robust to ec2.AmazonLinuxImage() as an example.
rix0rrr
approved these changes
Oct 19, 2018
|
Thank you! |
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.
Summary
This patch fixes an AutoScalingGroup example in the README file.
Test
cdk 0.12.0 (build 2dc324e).Notes