Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudfront): Distribution support for logging, geo restrictions, http version and IPv6 #9635

Merged
merged 8 commits into from
Aug 12, 2020
Merged

feat(cloudfront): Distribution support for logging, geo restrictions, http version and IPv6 #9635

merged 8 commits into from
Aug 12, 2020

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Aug 12, 2020

Adding support for most of the missing attributes for DistributionProps,
including HttpVersion, Logging, Geo restrictions, and WAF ACLs.
The only missing property now is "aliases", which needs some design work
alongside the certificate usage.

I also added two integ tests for Distribution, as previously all integ tests
were only in the aws-cloudfront-origins module.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@njlynch
feat(cloudfront): expand DistributionProps for more complete coverage
d5972cc 
Adding support for most of the missing attributes for `DistributionProps`,
including HttpVersion, Logging, Geo restrictions, and WAF ACLs.
The only missing property now is "aliases", which needs some design work
alongside the certificate usage.

I also added two integ tests for `Distribution`, as previously all integ tests
were only in the `aws-cloudfront-origins` module.
@njlynch njlynch requested a review from a team August 12, 2020 13:53
@njlynch njlynch self-assigned this Aug 12, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 12, 2020
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Aug 12, 2020
nija-at
nija-at approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title needs to be reworked. Think of this going into the features section of our release notes.

Of course, you don't need to include every single property you've supported but some sort of grouping would help. Maybe "configure distribution with logging, geo restrictions, http version and IPv6"

packages/@aws-cdk/aws-cloudfront/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-cloudfront/lib/distribution.ts Show resolved Hide resolved
packages/@aws-cdk/aws-cloudfront/lib/geo-restriction.ts Show resolved Hide resolved
@njlynch njlynch changed the title feat(cloudfront): expand DistributionProps for more complete coverage feat(cloudfront): Distribution support for logging, geo restrictions, http version and IPv6 Aug 12, 2020
@njlynch njlynch requested a review from nija-at August 12, 2020 16:35
@njlynch njlynch removed the pr/do-not-merge This PR should not be merged at this time. label Aug 12, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ee4b079
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4c62702 into master Aug 12, 2020
@mergify mergify bot deleted the njlynch/cf-dist-props branch August 12, 2020 19:19
@njlynch njlynch mentioned this pull request Aug 19, 2020
Closed
njlynch added a commit that referenced this pull request Aug 19, 2020
@njlynch
fix(cloudfront): Distribution ignores webAclId
fdfac7f 
This was missed in #9635; the property was added to DistributionProps but not
included in the underlying CfnDistribution.

fixes #9824
@njlynch njlynch mentioned this pull request Aug 19, 2020
Merged
mergify bot pushed a commit that referenced this pull request Aug 19, 2020
@njlynch
fix(cloudfront): Distribution ignores webAclId (#9828)
366c781 
This was missed in #9635; the property was added to DistributionProps but not
included in the underlying CfnDistribution.

fixes #9824

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at Awaiting requested review from nija-at

Assignees

@njlynch njlynch

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njlynch @aws-cdk-automation @nija-at