-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: small fixes to DESIGN_GUIDELINES.md #9534
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
cc3a754
to
d5592ea
Compare
It looks like this document also has typos with bullet points in several other places, is it possible you could also fix those? 😄 |
@Chriscbr sure, it's just quite long and dense for me so it takes time :D I'm going through it and I didn't want to forget those points so I created the PR, will provide a new commit when I'm done 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't see this earlier. I actually did (what I hope) is a fairly robust pass at this in #9640 yesterday. I've just included your first change (linking awslint) in mine so there will be clean merges, and am approving this one so you get the contribution credit. :)
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license