Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small fixes to DESIGN_GUIDELINES.md #9534

Merged
merged 2 commits into from
Aug 13, 2020

Conversation

shaftoe
Copy link
Contributor

@shaftoe shaftoe commented Aug 8, 2020


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@shaftoe shaftoe force-pushed the fix-guidelines-doc branch from cc3a754 to d5592ea Compare August 8, 2020 08:41
@Chriscbr
Copy link
Contributor

Chriscbr commented Aug 8, 2020

It looks like this document also has typos with bullet points in several other places, is it possible you could also fix those? 😄

@shaftoe
Copy link
Contributor Author

shaftoe commented Aug 9, 2020

@Chriscbr sure, it's just quite long and dense for me so it takes time :D I'm going through it and I didn't want to forget those points so I created the PR, will provide a new commit when I'm done 👍🏻

@SomayaB SomayaB self-assigned this Aug 10, 2020
njlynch added a commit that referenced this pull request Aug 13, 2020
@njlynch njlynch self-requested a review August 13, 2020 08:21
@njlynch njlynch changed the title Small fixes to DESIGN_GUIDELINES.md chore: small fixes to DESIGN_GUIDELINES.md Aug 13, 2020
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't see this earlier. I actually did (what I hope) is a fairly robust pass at this in #9640 yesterday. I've just included your first change (linking awslint) in mine so there will be clean merges, and am approving this one so you get the contribution credit. :)

@mergify
Copy link
Contributor

mergify bot commented Aug 13, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shaftoe
Copy link
Contributor Author

shaftoe commented Aug 13, 2020

Sorry I didn't see this earlier. I actually did (what I hope) is a fairly robust pass at this in #9640 yesterday. I've just included your first change (linking awslint) in mine so there will be clean merges, and am approving this one so you get the contribution credit. :)

@njlynch thanks!!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e6f1e4a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 13, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a48e95a into aws:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants