feat(eks): deprecate "kubectlEnabled: false" #9454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying `kubectlEnabled: false`, it _implicitly_ meant that the underlying resource behind the construct would be the stock `AWS::EKS::Cluster` resource instead of the custom resource used by default. This means that many new capabilities of EKS would not be supported (e.g. Fargate profiles).
Clusters backed by the custom-resource have all the capabilities (and more) of clusters backed by `AWS::EKS::Cluster`. Therefore, we decided that going forward we are going to support only the custom-resource backed solution.
To that end, after this change, defining an `eks.Cluster` with `kubectlEnabled: false` will throw an error with the following message:
The "eks.Cluster" class no longer allows disabling kubectl support.
As a temporary workaround, you can use the drop-in replacement class `eks.LegacyCluster`
but bear in mind that this class will soon be removed and will no longer receive additional
features or bugfixes. See #9332 for more details
Resolves #9332
BREAKING CHANGE: The experimental `eks.Cluster` construct no longer supports setting `kubectlEnabled: false`. A temporary drop-in alternative is `eks.LegacyCluster`, but we have plans to completely remove support for it in an upcoming release since `eks.Cluster` has matured and should provide all the needed capabilities. Please comment on #9332 if there are use cases that are not supported by `eks.Cluster`.
I think its a pretty useful way to encapsulate the custom resource. I rather keep it. |
SomayaB
added
the
pr/breaking-change
…ate-kubectl-disabled
iliapolo
reviewed
Aug 6, 2020
Removed the comment - this |
Yeah i just meant the comment 👍 |
iliapolo
approved these changes
Aug 6, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
eladb
pushed a commit
that referenced
this pull request
Aug 10, 2020
When specifying `kubectlEnabled: false`, it _implicitly_ meant that the underlying resource behind the construct would be the stock `AWS::EKS::Cluster` resource instead of the custom resource used by default. This means that many new capabilities of EKS would not be supported (e.g. Fargate profiles).
Clusters backed by the custom-resource have all the capabilities (and more) of clusters backed by `AWS::EKS::Cluster`. Therefore, we decided that going forward we are going to support only the custom-resource backed solution.
To that end, after this change, defining an `eks.Cluster` with `kubectlEnabled: false` will throw an error with the following message:
The "eks.Cluster" class no longer allows disabling kubectl support.
As a temporary workaround, you can use the drop-in replacement class `eks.LegacyCluster`
but bear in mind that this class will soon be removed and will no longer receive additional
features or bugfixes. See #9332 for more details
Resolves #9332
BREAKING CHANGE: The experimental `eks.Cluster` construct no longer supports setting `kubectlEnabled: false`. A temporary drop-in alternative is `eks.LegacyCluster`, but we have plans to completely remove support for it in an upcoming release since `eks.Cluster` has matured and should provide all the needed capabilities. Please comment on #9332 if there are use cases that are not supported by `eks.Cluster`.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying
kubectlEnabled: false, it implicitly meant that the underlying resource behind the construct would be the stockAWS::EKS::Clusterresource instead of the custom resource used by default. This means that many new capabilities of EKS would not be supported (e.g. Fargate profiles).Clusters backed by the custom-resource have all the capabilities (and more) of clusters backed by
AWS::EKS::Cluster. Therefore, we decided that going forward we are going to support only the custom-resource backed solution.To that end, after this change, defining an
eks.ClusterwithkubectlEnabled: falsewill throw an error with the following message:Resolves #9332
BREAKING CHANGE: The experimental
eks.Clusterconstruct no longer supports settingkubectlEnabled: false. A temporary drop-in alternative iseks.LegacyCluster, but we have plans to completely remove support for it in an upcoming release sinceeks.Clusterhas matured and should provide all the needed capabilities. Please comment on #9332 if there are use cases that are not supported byeks.Cluster.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license